[3.8] venv: Update Aspen URL in 'activate' script comment#21797
Merged
Conversation
zetadev.com changed ownership in 2019
Member
|
Thanks for the report. PR should be made to master and they will be backported to 3.9 and 3.8 . 3.7 branch is in security fixes only mode. Please refer to https://devguide.python.org/ . I guess it's good to open an issue in https://bugs.python.org to discuss this but I will leave it up to you since it's trivial. |
Contributor
Author
|
Thanks @tirkarthi. I guess my only concern is:
I would have done so, but as I mentioned in the initial post:
I'm... just not sure how to submit a PR against the master branch to correct this URL, when this URL isn't there anymore on the master branch. Both the comment and the code it describes were subsequently dropped as part of 48ede6b. Obviously 48ede6b could be backported, in theory, but then that would alter the behavior of the script from previous 3.8.x releases. This PR avoids any changes to functionality, even as side-effects, which seemed preferable to me. But please let me know how you'd like to proceed. |
Member
|
Sorry, I missed that part. In that case I will let venv module author, @vsajip to decide on this change. |
vsajip
approved these changes
Aug 19, 2020
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in the venv
activatescript (as well asactivate.cshandactivate.fish) referencing Aspen magic directories lists a "further information" URL for Aspen at the zetadev.com website. zetadev.com changed ownership in 2019, and now redirects to a server in China with an expired security certificate.Out of an abundance of caution, while not changing the code for the activate scripts, this PR updates the URL in those comments to reference Aspen's new documentation home at https://aspen.io/.
No issue created, as I suspect this falls within the definition of a "trivial" change. Please let me know if I'm wrong about that, and I'll open the necessary issue(s).
While filed against the 3.8 branch, strictly speaking this is not a backported PR. The comment in question was entirely removed from the script between Python 3.8 and 3.9.
(IMHO this should probably be backported to 3.7 and 3.6, as well. I'll happily file those PRs if needed.)
Automerge-Triggered-By: @vsajip